matrix-react-sdk icon indicating copy to clipboard operation
matrix-react-sdk copied to clipboard

Published 20 hours ago • verified publisher icon matrix-org

MessageComposerButtons: code cleanup, move buttons out of dropdown

Open ckiee opened this issue 3 years ago • 2 comments

If we're in wide mode, we might away steal a bit more space from the text input to save a click for users.

There's 3 options in this PR:

  1. First commit only (just a code refactor; same as before this PR) Screen Shot 2022-06-29 at 06 23 27
  2. Second commit Screen Shot 2022-06-29 at 06 22 18
  3. All commits Screen Shot 2022-06-29 at 06 22 29

Opinions? I think #2 is too overloaded.

Notes: TBD Type: enhancement

Here's what your changelog entry will look like:

✨ Features

  • TBD (#8930). Contributed by @ckiee.

ckiee avatar Jun 29 '22 03:06 ckiee

@ckiee It looks to me that you're working on the 'new' message composer which was redacted recently due to a lot of regressions... Is it intentional? Or does it not really matter here?

luixxiul avatar Jun 29 '22 03:06 luixxiul

@ckiee It looks to me that you're working on the 'new' message composer which was redacted recently due to a lot of regressions. Is it intentional?

Oops. I hadn't pulled on develop in a few days. Will rebase.

(Also, I love the use of redacted in "which was redacted recently". You are immersed in the Matrix.)

ckiee avatar Jun 29 '22 03:06 ckiee