matrix-react-sdk icon indicating copy to clipboard operation
matrix-react-sdk copied to clipboard

Published 20 hours ago • verified publisher icon matrix-org

MSC2545 support proof-of-concept

Open ckiee opened this issue 3 years ago • 1 comments

There are a bazillion things wrong with this code, but I just wanted to put it out there in case anyone else would like to work on it, and just to get feedback about the idea.

Screenshot of element showing the new stickers pop-up

Type: enhancement

Here's what your changelog entry will look like:

✨ Features

  • MSC2545 support proof-of-concept (#8897). Contributed by @ckiee.

TODO

Blockers

  • [ ] (maybe?) Ensure the mediaFromMxc stuff would probably break in encrypted rooms.
  • [ ] Move some stuff to matrix-js-sdk
  • [ ] Check if there's changes after the initial getAccountData.
  • [ ] Lab-gate this
  • [x] Rename component from Cookiestickerpicker.
  • [x] Sticker search!

Future

  • [ ] Support images as custom emojis too
  • [ ] Add a way to add image pack rooms to your user

ckiee avatar Jun 25 '22 19:06 ckiee

cc matrix-org/matrix-spec-proposals#2545

ckiee avatar Jun 25 '22 21:06 ckiee

@ckiee is this PR still active? We want to consolidate the amount of competing PRs in order for the feature to move forward. Product is blocking https://github.com/matrix-org/matrix-react-sdk/pull/9240 since they have to review all competing PRs that are open. If not, please close this PR so https://github.com/matrix-org/matrix-react-sdk/pull/9240 can go forward. We support MSC2545 in that PR and can add further features once merged.

JiffyCat avatar Jul 27 '23 00:07 JiffyCat

Closing in favor of #9240 since it is clearly superior, though it is worth clearly noting that this PR implements the sticker portion of 2545, which has considerable overlap with the emojo section.

ckiee avatar Jul 29 '23 02:07 ckiee