matrix-react-sdk icon indicating copy to clipboard operation
matrix-react-sdk copied to clipboard

conversation export named after room

Open Sinharitik589 opened this issue 3 years ago • 3 comments

Fixes https://github.com/vector-im/element-web/issues/19724

Signed-off-by: Ritik Kumar [email protected]


Here's what your changelog entry will look like:

✨ Features

  • conversation export named after room (#7992). Fixes vector-im/element-web#19724. Contributed by @Sinharitik589.

Preview: https://pr7992--matrix-react-sdk.netlify.app ⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

Sinharitik589 avatar Mar 05 '22 05:03 Sinharitik589

Codecov Report

Merging #7992 (e73fa9b) into develop (3e31fdb) will decrease coverage by 4.06%. The diff coverage is 0.00%.

:exclamation: Current head e73fa9b differs from pull request most recent head 6df5cbd. Consider uploading reports for the commit 6df5cbd to get more accurate results

@@             Coverage Diff             @@
##           develop    #7992      +/-   ##
===========================================
- Coverage    30.85%   26.79%   -4.07%     
===========================================
  Files          893      866      -27     
  Lines        50793    51950    +1157     
  Branches     12928    13163     +235     
===========================================
- Hits         15671    13918    -1753     
- Misses       35122    38032    +2910     
Impacted Files Coverage Δ
src/utils/exportUtils/Exporter.ts 10.94% <0.00%> (-0.42%) :arrow_down:
src/utils/exportUtils/JSONExport.ts 0.00% <0.00%> (ø)
src/utils/exportUtils/PlainTextExport.ts 27.63% <0.00%> (ø)
src/utils/read-receipts.ts 0.00% <0.00%> (-100.00%) :arrow_down:
src/stores/local-echo/RoomEchoContext.ts 0.00% <0.00%> (-100.00%) :arrow_down:
src/customisations/helpers/UIComponents.ts 0.00% <0.00%> (-100.00%) :arrow_down:
...list/algorithms/tag-sorting/AlphabeticAlgorithm.ts 0.00% <0.00%> (-100.00%) :arrow_down:
src/utils/colour.ts 0.00% <0.00%> (-94.12%) :arrow_down:
...c/components/views/location/LocationViewDialog.tsx 0.00% <0.00%> (-92.31%) :arrow_down:
src/components/views/rooms/SearchBar.tsx 0.00% <0.00%> (-89.29%) :arrow_down:
... and 607 more

codecov[bot] avatar Mar 15 '22 08:03 codecov[bot]

This PR contends with https://github.com/matrix-org/matrix-react-sdk/pull/8558

t3chguy avatar May 20 '22 15:05 t3chguy

Apologies for slow followup. After discussing with Michael, we decided that we would like to proceed with this PR and will request for the competing PR to be split up and cover the time format in the filename.

kittykat avatar Jul 26 '22 12:07 kittykat

Thanks for the PR! Sorry it took so long to get considered. We've decided to merge the changes from this and https://github.com/matrix-org/matrix-react-sdk/pull/9142 into a single PR to ease the requirements raised by the Product team, and are closing this PR as a result. Hopefully this should mean the code goes live soon.

You can see the new PR here: https://github.com/matrix-org/matrix-react-sdk/pull/9440

turt2live avatar Oct 17 '22 23:10 turt2live