matrix-react-sdk icon indicating copy to clipboard operation
matrix-react-sdk copied to clipboard

Add more encryption properties to PostHog

Open uhoreg opened this issue 1 year ago • 5 comments

Fixes https://github.com/element-hq/element-web/issues/27168

Checklist

  • [ ] Tests written for new code (and old code if feasible).
  • [ ] New or updated public/exported symbols have accurate TSDoc documentation.
  • [ ] Linter and other CI checks pass.
  • [ ] Sign-off given on the changes (see CONTRIBUTING.md).

uhoreg avatar Apr 12 '24 00:04 uhoreg

Sorry, forgot to create this PR as a draft

uhoreg avatar Apr 12 '24 00:04 uhoreg

This PR conflicts with https://github.com/matrix-org/matrix-react-sdk/pull/12389 AFAICT, most of it should merge cleanly. Conflicts that I can see off-hand are:

  • 12389 removes an argument from the eventDecrypted method, while this PR adds an argument
  • both PRs add an argument to the createFailedDecryptionEvent in the test file enable setting properties. This PR needs to set the sender, 12389 needs to set the error code. I've changed createFailedDecryptionEvent in this PR to accept an object with properties to set, rather than trying to decide whether the sender or error code should be the first argument to the function.
  • this PR adds test that use the MockDecryptionError class removed in 12389. The tests will need to be adjusted accordingly.

I'd recommend that 12389 gets merged before this one, and I'll handle the conflicts.

uhoreg avatar Apr 17 '24 01:04 uhoreg

@BillCarsonFr what does the userTrustsOwnIdentity flag in the PostHog schema represent? I'm trying to figure out how to map it to the functions that the crypto API gives us. Is isCrossSigningReady good enough?

uhoreg avatar Apr 17 '24 01:04 uhoreg

@BillCarsonFr what does the userTrustsOwnIdentity flag in the PostHog schema represent? I'm trying to figure out how to map it to the functions that the crypto API gives us. Is isCrossSigningReady good enough?

I think getUserVerificationStatus() would be better

BillCarsonFr avatar May 02 '24 06:05 BillCarsonFr

merged latest develop

uhoreg avatar May 03 '24 03:05 uhoreg

Oh, it still needs an Element Web reviewer. I've requested review from Robin and Rich because those were the people GitHub had randomly chosen initially.

uhoreg avatar May 07 '24 16:05 uhoreg

I think that I've addressed all the requested changes.

uhoreg avatar May 13 '24 23:05 uhoreg