matrix-react-sdk icon indicating copy to clipboard operation
matrix-react-sdk copied to clipboard

Element Call: fix widget shown while its still loading (`waitForIframeLoad=false`)

Open toger5 opened this issue 1 year ago • 1 comments

Show loading spinner also if waitForIframeLoad = false. Configure EC so it waits for the content loaded action.

This prohibits the error message:

Uncaught (in promise) Error: Improper sequence: not expecting ContentLoaded event if waitForIframeLoad is true (default=true)

!WARNING This breaks compatibility with the full mesh branch. I would like to discuss here if/when we can do that.

Signed-off-by: Timo K [email protected]

Checklist

  • [ ] Tests written for new code (and old code if feasible)
  • [ ] Linter and other CI checks pass
  • [ ] Sign-off given on the changes (see CONTRIBUTING.md)

toger5 avatar Feb 27 '24 20:02 toger5

@dbkr updated the title and added T-Enhancement.

So basically we are deciding that now is the time to drop support for any version of EC that doesn't support waitForIframeLoad: false? I think that seems fine: it has been quite some time. As you say, full mesh will no longer work but that may be fine.

And yeah, I'm not convinced about only passing the loading flag if waitForIframeLoad was true, I can't really make much sense of it and I can't think why we would have done it. I can't wait until this confusing flag is gone forever.

Nice that you agree with those.

toger5 avatar Feb 28 '24 20:02 toger5