construct icon indicating copy to clipboard operation
construct copied to clipboard

Channel display name not replacing #-style name

Open Valinwolf opened this issue 6 years ago • 6 comments

screenshot

What should say "Construct Test" says "#construct:flobob.ovh"

Valinwolf avatar Aug 01 '19 13:08 Valinwolf

If you don't mind, can you open up devtools in Riot and check the room state to see if it contains an m.room.name and m.room.canonical_alias? Room name calculations are actually part of the spec, and complicated enough to still remain a mystery to me.

Also try to Clear Cache and reload and see if the name is recalculated

jevolk avatar Aug 01 '19 17:08 jevolk

If you don't mind, can you open up devtools in Riot and check the room state to see if it contains an m.room.name and m.room.canonical_alias? Room name calculations are actually part of the spec, and complicated enough to still remain a mystery to me.

Also try to Clear Cache and reload and see if the name is recalculated

For the kicks, shortly after making this post I used the room settings to edit the name. I was surprised to find it actually let me set the name. As such it does have m.room.name, but not m.room.canonical_alias. It also has not loaded a channel avatar for it, as you can see in the screenshot, which is probably related to the same underlying issue.

As for clear cache and reload, I've done it about (give or take a half dozen) 9 times since I joined the channel with no change in the channel. Anytime I find an issue I hit that button, about half the time it actually fixes the issue lol.

Valinwolf avatar Aug 01 '19 21:08 Valinwolf

I was surprised to find it actually let me set the name.

This is not rejected with an error while construct is in development, my apologies for it being unexpected.

As such it does have m.room.name, but not m.room.canonical_alias.

Yes, I'm really not sure why Riot sees the m.room.name but doesn't apply it. There is likely more Construct can do to feed Riot exactly what it expects from Synapse and when and how it expects it, but I don't know at this point.

It also has not loaded a channel avatar for it, as you can see in the screenshot, which is probably related to the same underlying issue.

But it does have an m.room.avatar event present in the room state?

jevolk avatar Aug 01 '19 21:08 jevolk

I wrote my last message without having noticed that your address bar says riot.im. Are you using the matrix.org server in that screenshot? I was under the impression you're reporting a bug using Riot on a Construct server, no?

jevolk avatar Aug 01 '19 21:08 jevolk

No, I'm using my Construct server in that screenshot so, yes, it is a bug using Riot on a Construct server.

EDIT: Sorry, I didn't notice your first message because I replied on FastHub after fast scrolling to the bottom and didn't even think about the first part of your last message (sorry this is early for me). To answer your previous question, no m.room.avatar is not present.

Valinwolf avatar Aug 01 '19 21:08 Valinwolf

As such it does have m.room.name, but not m.room.canonical_alias.

Yes, I'm really not sure why Riot sees the m.room.name but doesn't apply it. There is likely more Construct can do to feed Riot exactly what it expects from Synapse and when and how it expects it, but I don't know at this point.

I think there's a misunderstanding... there is only m.room.name because I set it. You can see in the event details, that it was actually me that set it:

{
  "content": {
    "name": "Construct Test"
  },
  "depth": 40753,
  "event_id": "$TIhmVTrf_SkWYhvT5w-9RVS1TrLUhEmr8r1BsdjXRU8:w0lfr.net",
  "origin_server_ts": 1564666308896,
  "room_id": "!AAAANTUiY1fBZ230:zemos.net",
  "sender": "@solinwolf:w0lfr.net",
  "state_key": "",
  "type": "m.room.name",
  "unsigned": {
    "age": 90
  }
}

Valinwolf avatar Aug 02 '19 00:08 Valinwolf