ipympl icon indicating copy to clipboard operation
ipympl copied to clipboard

NPM Relase action broken

Open ianhi opened this issue 3 years ago • 6 comments

There seem to be two issues:

  1. jupyterlab is not installed for the npm section
$ jupyter labextension build --development True .
/bin/sh: 1: jupyter: not found
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
  1. Some sort of issue with NPM keys
npm notice 
npm ERR! code ENEEDAUTH
npm ERR! need auth This command requires you to be logged in to https://registry.npmjs.org/
npm ERR! need auth You need to authorize this machine using `npm adduser`

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2022-04-13T18_03_18_823Z-debug-0.log
Error: Process completed with exit code 1.

1 is an easy fix, we just need to pip install jupyterlab

  1. I think will require intervention from @tacaswell or someone else with the power mess around with repo secrets

ianhi avatar Apr 13 '22 18:04 ianhi

There may be some hints for 2 here: https://sergiodxa.com/articles/github-actions-npm-publish

possible using --access public and maybe specifying the registry

ianhi avatar Apr 13 '22 18:04 ianhi

For now I manually publish version 0.11.0

ianhi avatar Apr 13 '22 18:04 ianhi

We could probably adopt jupyter-releaser and remove the action

martinRenou avatar Apr 14 '22 07:04 martinRenou

@ianhi Email me so we can coordinate on what secrets need to be where.

tacaswell avatar Apr 30 '22 22:04 tacaswell

Just ran into this again with 0.11.3 https://github.com/matplotlib/ipympl/actions/runs/4187384014/jobs/7257141068

And by coming back here realized that I never followed up... though looking again im not sure that the secrets need to be updated? they're already present

ianhi avatar Feb 15 '23 19:02 ianhi

As a follow-up to #416, was this fixed already? :)

Wondering if I still need to match our user-side ipympl versions in kernels when running on HPC-center provided Jupyter instances.

ax3l avatar May 24 '23 23:05 ax3l