react-native-health-connect icon indicating copy to clipboard operation
react-native-health-connect copied to clipboard

Published 20 hours ago • verified publisher icon matinzd

fix(expo-config-plugin): rework expo-config-plugin to fix `lateinit` error

Open xseignard opened this issue 1 year ago • 3 comments

Updated the expo-config-plugin to handle:

  • Android 13 and lower with an activity triggered by androidx.health.ACTION_SHOW_PERMISSIONS_RATIONALE intent
  • Android 14 with an activity-alias triggered by android.intent.action.VIEW_PERMISSION_USAGE intent
  • The activity code is to be provided by users
  • Updated docs

Tested on expo 49/java MainActivity & expo 50/kotlin MainActivity

Fixes #71

xseignard avatar Mar 25 '24 17:03 xseignard

Hey!

Thanks for the contribution and helping with the expo plugin. I will review it as soon as I find some time.

matinzd avatar Mar 26 '24 11:03 matinzd

Hello @brentvatne Thanks for your review. I clearly think migrating this library to expo modules is out of scope of this PR

xseignard avatar Apr 02 '24 11:04 xseignard

Hello @brentvatne Thanks for your review. I clearly think migrating this library to expo modules is out of scope of this PR

my suggestion was not to migrate it to expo modules, but to use the expo modules api when it is already available in the library consumer's app to automatically set up parts of this library, rather than use regexes to modify code

brentvatne avatar Apr 17 '24 01:04 brentvatne

Closing this in favor of the adapter library:

https://github.com/matinzd/expo-health-connect

Thanks for the contribution!

matinzd avatar Jun 29 '24 15:06 matinzd