Matin Zadeh Dolatabad

Results 251 comments of Matin Zadeh Dolatabad

Would you please rebase your branch with the master?

Closed in favor of: https://github.com/lottie-react-native/lottie-react-native/pull/992 After merging #992 you can direcetly pass anything you want to the native lottie view itself.

Can you also test this on native ios and android Lottie implementation? @27leaves

Please open a new issue in Lottie iOS and link this issue there so that they can follow up on it.

> First of all, thanks a lot for this workaround. It seems like parsing of negative durations doesn't work. > > ``` > parseISODuration('P-1D'); > > // results in Invalid...

> Please rebase and reformat code with the default Prettier config, thanks! Rebased it now and all suggestions are applied. However I don't know how to test generated docs to...

I guess we may need to add more test cases as I have heard a lot about negative values. WDYT? @kossnocorp

@andrioid There are some test cases that the current implementation is not covering. I will try to update the PR accordingly.

@yjukaku Yes, you are right! The test case I found was not related to supporting negative values. Also negative values are not in the standard as far as I checked....

> @matinzd any idea when your PR could go live? It's a really handy method to have inside date-fns As I communicated with @kossnocorp, this [PR](https://github.com/date-fns/date-fns/pull/3151) will be included in...