Ben Boeckel

Results 538 comments of Ben Boeckel
trafficstars

> It does not lose type safety: if you provide SomeOtherStruct which does not implement IsValidVariablesFor, it will be rejected by the constraint on build_query: V: IsValidVariablesFor, in the same...

> Saying () is valid a valid Variables for any query Q is prevented by the fact we can implement a trait on a type only if either the trait...

Hrm. Examples are not so easy. They'd need to be moved into a crate directly (probably `graphql_client`?) rather than living at the workspace level. See rust-lang/cargo#7467 for a cargo-level solution...

I suspect GitHub Actions is unsuitable due to the time limits and such. 5 builds, ~8 min per build means we have 50 PR updates (including the merge) per month....

On November 10, 2019 11:58:10 PM EST, Hirokazu Hata wrote: >I'm sorry, I was mistaken. The repository setting can only be changed >by the owner. :p You should be able...

See also #117 which resolved to just mention this limitation in the readme.

I think adding `extensions` to [this type](https://docs.rs/graphql_client/0.9.0/graphql_client/struct.Response.html) would be the way to go.

The status is that it works for me (Linux and GDC with a patched Ninja, but that patch may be unnecessary with the latest updates) and @trentforkert has done some...

No, @trentforkert's approach is the right one for the long run. It gets dependencies right (including for VS, Ninja, etc.) and integrates properly with IDEs (such as VisualD). It needs...