MathJax-src icon indicating copy to clipboard operation
MathJax-src copied to clipboard

Newenvironment with "old" environment not working

Open zorkow opened this issue 1 year ago • 4 comments

Example:

\newenvironment{boxed}
    {
    \begin{array}{|c|c|}\hline
    }
    {
    \\\hline
    \end{array} 
    }
\begin{boxed}a&b\\c&d\end{boxed}

Worked fine in 3.2.2, stopped working in 4.0.0-alpha.1.

zorkow avatar Oct 07 '24 12:10 zorkow

I suspect 9ed1360c2c4cb1c89d71f5951248024ca062020a is the commit that is the culprit, but need to look further

dpvc avatar Oct 07 '24 15:10 dpvc

The issue that commit fixed is described in #856.

dpvc avatar Oct 07 '24 15:10 dpvc

Thanks. Tested and lgtm. writes the reviewer confidently. That's because we did not have a complete set of tests!

zorkow avatar Oct 07 '24 19:10 zorkow

That's because we did not have a complete set of tests!

Yes, certainly. I know you are working on that, and I will, too.

I have made a PR to fix the problem. Sorry about the duplicate PRs, the first was opened as a draft, and I couldn't find where to change that, so resubmitted it.

dpvc avatar Oct 08 '24 15:10 dpvc

I added the tsets from #1139 into the test-newcommand branch. If you had others, you can add a commit to that. Closing this issue now.

dpvc avatar Feb 06 '25 13:02 dpvc