command-exists icon indicating copy to clipboard operation
command-exists copied to clipboard

Published 20 hours ago • verified publisher icon mathisonian

Bug/35

Open rbbl-dev opened this issue 3 years ago • 10 comments
trafficstars

aims to fix https://github.com/mathisonian/command-exists/issues/35

rbbl-dev avatar Mar 28 '22 21:03 rbbl-dev

@mathisonian is it ok that i upgraded the node versions that get tested? 4 to 9 seems a bit too old given that their docker only reaches back to 12

rbbl-dev avatar Mar 28 '22 21:03 rbbl-dev

node 10 seems to be the lowest supported version with my changes.

can someone confirm if/how #35 affects windows and mac?

can't check on mac. windows will take me some time.

rbbl-dev avatar Mar 28 '22 21:03 rbbl-dev

so i played around a bit and i think this false positive can not corrur on windows 🤔

rbbl-dev avatar Mar 28 '22 22:03 rbbl-dev

Hi @rbbl-dev. Thanks for the PR. I'm okay dropping support for the older versions of node - we should update the docs & package.json to reflect this as well. It also looks like there are some files added that don't need to be included (the .idea folder). Could you add that to .gitignore?

mathisonian avatar Mar 29 '22 19:03 mathisonian

It also looks like there are some files added that don't need to be included (the .idea folder). Could you add that to .gitignore?

sure thing.

can you test on osx?

rbbl-dev avatar Mar 29 '22 21:03 rbbl-dev

~~the issue on windows seems to be that where is not available on powershell and powershell to be the default windows console.~~

done goofed 😆

rbbl-dev avatar Mar 30 '22 19:03 rbbl-dev

@mathisonian i would be ready with that PR

rbbl-dev avatar Apr 03 '22 12:04 rbbl-dev

Hey @rbbl-dev sorry for the slowness, I can test on a mac this week.

mathisonian avatar Apr 09 '22 22:04 mathisonian

no worries. i know how life can be :)

rbbl-dev avatar Apr 10 '22 09:04 rbbl-dev