expression-evaluator-c-sharp icon indicating copy to clipboard operation
expression-evaluator-c-sharp copied to clipboard

Feature/replace regex

Open nastymorbol opened this issue 2 years ago • 2 comments

Replaced some Regex with constant expressions for performance improvement.

nastymorbol avatar Dec 30 '22 19:12 nastymorbol

I considered making similar changes, but was going to recommend using the built it char static functions instead. Specifically, char.IsAsciiDigit or char.IsDigit, char.IsAsciiLetter or char.IsLetter etc.

s-michael-telford avatar Jan 27 '23 16:01 s-michael-telford

Since the static char functions are unicode, i prefer to work with explicit ASCII characters. Unfortunately, I already had problems where my customers used some unicode characters using copy paste, which I then misinterpreted.

nastymorbol avatar Jan 27 '23 23:01 nastymorbol