MarkdownLivePreview icon indicating copy to clipboard operation
MarkdownLivePreview copied to clipboard

ST4: 4065+ HTMLSheet Updates

Open TerminalFi opened this issue 5 years ago • 4 comments

Should be a ST4 only branch

  • Requires => 4074

Will update the Package Control Channel to support ST3 and ST4 tags and set appropriate ST4 version requirement

Major Changes

  • [x] Removes 2markdown.py in favor of Mdpopups
    • Provides proper code highlighting and handles md2html
  • [x] Removes markdown2html.py implements ImageParser.py
    • Utilizes 95% of the same code with minor tweaks
  • [x] Adds add_on_change for monitoring the SETTING_DELAY_BETWEEN_UPDATES to update the delay in real time. (Could be back ported)
  • [x] Adds MdlpEraseCommand for erasing a view when called from on_pre_close Should probably be implemented on the ST3 branch to fix a bug in which EventListener doesn't have a edit object https://github.com/math2001/MarkdownLivePreview/blob/ec27d980a3ebd4c73c23f9036e5b4edf1dea2e27/MarkdownLivePreview.py#L130-L135
  • [x] Replaces Phantoms with HTMLSheets which are implemented in ST4065
  • [x] Implements a PREVIEW_VIEWS hash map to allow for multiple markdown previews (Could be back ported)
  • [x] Adds a syntax setting that allows you to enable the plugin on different syntax files (Could be back ported)
  • [ ] #22

Fixes

fixes #94 - Fixed with ST4 Changes. Likely can fix in ST3 by using Mdpopups but not HTMLSheet fixes #98 via facelessuser/sublime-markdown-popups@5c65d6f fixes #103 fixes #104 fixes #106

TerminalFi avatar Apr 27 '20 18:04 TerminalFi

@TheSecEng: please add to the above message


fixes #98 via facelessuser/sublime-markdown-popups@5c65d6f
fixes #103
fixes #104

jrappen avatar Apr 27 '20 18:04 jrappen

ST Build 4074 and mdpopups v3.7.0 had breaking changes due to Sublime no longer supporting cmd and args for sublime.Window.new_html_sheet, at least breaking the 4065-4073 behavior.

Code is fine as is, but requirement should be bumped.

jrappen avatar May 04 '20 11:05 jrappen

Why did work on this stopped ?

AmjadHD avatar Oct 23 '20 05:10 AmjadHD

Why did work on this stopped ?

Why did work on this stopped ?

I just am in the middle of moving and what not. I’d be happy to get help with it.

I’ll start working on it again when I have time.

TerminalFi avatar Oct 23 '20 09:10 TerminalFi