crystaltoolkit icon indicating copy to clipboard operation
crystaltoolkit copied to clipboard

Duplicate RGB values for elements in ElementColorSchemes.yaml

Open tsmathis opened this issue 2 years ago • 3 comments

Two sets of two elements share duplicate RGB values in the VESTA color scheme in ElementColorSchemes.yaml. This leads to visual ambiguity in the rendered structures for materials with these elements in their chemical system.

VESTA: F and N : [176, 185, 230] Sr and Zr: [0, 255, 0]

Some examples: mp-770419, mp-601344

tsmathis avatar Jul 21 '23 21:07 tsmathis

This is true, but not our choice: these are reference color schemes determined by others.

I completely support the addition of a new Crystal Toolkit color scheme however, which we can make a default. Happy to discuss.

mkhorton avatar Jul 21 '23 22:07 mkhorton

Aside: this partly motivated the addition of the “Accessible” color scheme. This used a reference color scheme from literature suitable for people with color blindness, and constrained atoms to be their “regular” color if possible (i.e. close to CPK, oxygen red etc.)

This scheme is not fully successful yet since one of the colors in that scheme is white, so to really reach accessibility goals, it’d probably be better off switching to a black/darker viewport background when that scheme is enabled, or simply changing the white atom color to something else, but this was on the backlog.

mkhorton avatar Jul 21 '23 22:07 mkhorton

Good to know. Color schemes came up in a MP update call a few weeks ago in a related context, I can bring it up again in the next call to see what everyone thinks.

tsmathis avatar Jul 21 '23 22:07 tsmathis