material-automation icon indicating copy to clipboard operation
material-automation copied to clipboard

adding a separate repo specific var yaml file under .github/vars.yaml

Open yarneo opened this issue 7 years ago • 6 comments

yarneo avatar May 23 '18 16:05 yarneo

done in pr #26

yarneo avatar Jun 02 '18 23:06 yarneo

Do we now support .github/vars.yaml in repos now? I may have missed that in the PR but if we do that’s amaaazing!

jverkoey avatar Jun 03 '18 00:06 jverkoey

ah sorry, I should of clarified. I initially looked into adding the repo specific params under a vars.yaml file, but there is no out of the box implementation for yaml reading for swift unless i create my own reader or use a 3rd party, therefore I moved to using a Config.plist file that holds all the repo specific vars. Also there is a ConfigManager singleton that reads from that plist file and provides the vars. I may have missed something in the idea behind this issue though so please let me know if so.

yarneo avatar Jun 03 '18 00:06 yarneo

Ah: so the intent of this issue is to allow the installation repo to contain the plist file that configures the server’s behavior. The server would then, on any given input event, read the installation repo’s plist and use that to implement the behavior.

The end result is that, for example, the MDC iOS repo has a plist that configures its installation in a specific manner, while another installation might have a very different plist configuration.

jverkoey avatar Jun 03 '18 01:06 jverkoey

Reopening assuming the above isn’t what landed.

jverkoey avatar Jun 03 '18 01:06 jverkoey

This also means fewer deploys to the swift server in case we want to tweak behavior :)

jverkoey avatar Jun 03 '18 01:06 jverkoey