material-design-for-wordpress icon indicating copy to clipboard operation
material-design-for-wordpress copied to clipboard

Published 20 hours ago • verified publisher icon material-components

Evaluate whether any theme JS could be done in CSS or with AMP components

Open ravichdev opened this issue 4 years ago • 0 comments
trafficstars

Issue by mattchungxwp Friday Sep 18, 2020 at 18:43 GMT Originally opened as https://github.com/xwp/material-design-wp-plugin/issues/401

This pertains to the JS modules listed here: https://github.com/xwp/material-theme-wp/tree/develop/assets/src/front-end/components The context is AMP-compatibility. While there are several things that would need to change to make the theme AMP-compatible, removing the reliance on JS is a big one. I know this isn't easy, so I suggest a tiered approach:

  1. If there are any JS-based features that could be done with CSS transition or animations or in any browser-native way, then we can take care of that now. There may be no cases of this.
  2. If there are any JS-based features that could potentially be made AMP compatible (or have AMP-compatible alternatives wrapped in checks for whether the plugin is active), we should note these and add them as new issues if they are not easily implemented now.
  3. If there are any JS-based features that simply cannot be done in AMP, let's note these in this issue and then we can discuss what to do with them.

ravichdev avatar Apr 13 '21 12:04 ravichdev