material-components-android icon indicating copy to clipboard operation
material-components-android copied to clipboard

[MaterialDatePicker] Make the class open*.

Open jgavazzisp opened this issue 6 years ago • 3 comments

Is your feature request related to a problem? Please describe. I would suggest the class to be ~made public~ open, so we could attach the selection listener in a subclass and use "sharedViewModel" to deliver the selected date. At the moment in case of screen rotation, we need to detach the listeners and reattach when the new fragment is ready to avoid a memory leak.

Describe the solution you'd like Make the class public.

Describe alternatives you've considered Maybe another way to avoid subclassing it would be the old fashion OnInteractionListener on the parentFragment / activity.

We also happily accept pull requests.

jgavazzisp avatar Oct 16 '19 00:10 jgavazzisp

@jgavazzisp Can you elaborate what needs to be public?

ymarian avatar Feb 28 '20 16:02 ymarian

Another reason to make it open - this way, the dialog can be used with Jetpack navigation component as a destination defined in XML, which is a fantastic way of handling dialogs :)

jhutarek avatar Mar 25 '20 19:03 jhutarek

Any updates? :)

SteinerOk avatar May 09 '24 18:05 SteinerOk