material-components-android icon indicating copy to clipboard operation
material-components-android copied to clipboard

[MaterialButtonToggleGroup] No check icon displayed to indicate selected state

Open StellarSand opened this issue 1 year ago • 1 comments
trafficstars

Description: On the M3 components website, it is stated that a check icon will be displayed to indicate selected state.

However in the docs there's no mention of this. There is the app:icon property which sets the icon, but doesn't display the check icon when a button is selected in MaterialButtonToggleGroup.

Expected behavior:

Expected behavior Current behavior

Source code:

<com.google.android.material.button.MaterialButtonToggleGroup
        android:id="@+id/toggleGroup"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        app:singleSelection="true"
        app:selectionRequired="true"
        app:checkedButton="@id/trend">

        <com.google.android.material.button.MaterialButton
            android:id="@+id/fav"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            app:icon="@drawable/ic_fav"
            android:text="Favorites"
            style="?attr/materialButtonOutlinedStyle"/>

        <com.google.android.material.button.MaterialButton
            android:id="@+id/trend"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            app:icon="@drawable/ic_trend"
            android:text="Trending"
            style="?attr/materialButtonOutlinedStyle"/>

        <com.google.android.material.button.MaterialButton
            android:id="@+id/saved"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            app:icon="@drawable/ic_saved"
            android:text="Saved"
            style="?attr/materialButtonOutlinedStyle"/>

    </com.google.android.material.button.MaterialButtonToggleGroup>

Android API version: 34 (and very likely any other version too)

Material Library version: 1.12.0 1.13.0-alpha-06 1.13.0-alpha-05 1.13.0-alpha-04 1.13.0-alpha-03

StellarSand avatar Jul 21 '24 13:07 StellarSand

I'm also curious about this. It is rather strange that the Material Design website prominently shows this checkmark, but there does not appear to actually be a way to show it without manual work.

DanielRouxSA avatar Aug 29 '24 06:08 DanielRouxSA

I noticed this as well! It seems like we can add our own checkmark icon, but then you can't have an icon-only toggle group with checkmarks

sidorchukandrew avatar Jan 08 '25 15:01 sidorchukandrew

@manabu-nakamura Can you look into this? 😃

michael-winkler avatar Mar 18 '25 09:03 michael-winkler

https://github.com/material-components/material-components-android/issues/3241

michael-winkler avatar Mar 18 '25 12:03 michael-winkler

I don't think this feature is easy to implement...

https://github.com/material-components/material-components-android/pull/4596#issuecomment-2688004296:

Our current focus is on resolving critical bugs.

manabu-nakamura avatar Mar 18 '25 14:03 manabu-nakamura