material-components-android icon indicating copy to clipboard operation
material-components-android copied to clipboard

[Time picker] Presumably wrong time input field separator size

Open Gustl22 opened this issue 1 year ago • 0 comments
trafficstars

Description: Full description of issue here

The separator of the time input for the time picker is slightly too big. This results in a non centered oversized colon. For comparison in time picker specs:

Time picker:

  • Time picker time selector label text size: 57
  • Time picker time selector separator size: 57

Time input:

  • Time input time input field label text size: 45
  • Time input time input field separator size: 57 but should be 45 (see number 2 in image)
unnamed

Expected behavior: Screenshots and/or description of expected behavior The colon / separator should have the same font size as the label text, so that it is shown vertically centered.

Source code: https://github.com/material-components/material-components-android/blob/0d265b7ca54f9aedd3d3a1709dbee8a44c261384/lib/java/com/google/android/material/timepicker/res/values/tokens.xml#L51-L60

https://github.com/material-components/material-components-android/blob/0d265b7ca54f9aedd3d3a1709dbee8a44c261384/lib/java/com/google/android/material/timepicker/res/values/styles.xml#L130

https://github.com/material-components/material-components-android/blob/0d265b7ca54f9aedd3d3a1709dbee8a44c261384/lib/java/com/google/android/material/timepicker/res/values/themes.xml#L35-L36

There should be a value for @style/Widget.Material3.MaterialTimePicker.Button.Divider.

Minimal sample app repro: Every sample of time picker will do it.

Android API version: This concerns the Material Spec and not Android specifically.

Material Library version: 1.12.0

Device: Every

To help us triage faster, please check to make sure you are using the latest version of the library.

We also happily accept pull requests.

Gustl22 avatar May 05 '24 01:05 Gustl22