material-components-android icon indicating copy to clipboard operation
material-components-android copied to clipboard

Published 20 hours ago • verified publisher icon material-components

Remove redundant version checks

Open MGaetan89 opened this issue 2 years ago • 3 comments
trafficstars

Now that the minimum SDK version of Material Components is 19, there was a lot of code that could be simplified or removed.

MGaetan89 avatar Nov 14 '23 09:11 MGaetan89

Did you have time to have a look at this PR @hunterstich?

MGaetan89 avatar Nov 30 '23 16:11 MGaetan89

I've fixed the conflict in CarouselLayoutManagerRtlTest

MGaetan89 avatar Feb 27 '24 07:02 MGaetan89

@hunterstich I've updated the PR and removed some additional legacy code.

MGaetan89 avatar Apr 04 '24 15:04 MGaetan89

Thank you for working on this! I removed the change on the Badge file since it'd be best to refactor badge instead of just having a variable set to false, so that should be done in a separate change.

leticiarossi avatar May 09 '24 15:05 leticiarossi

Thank you for working on this! I removed the change on the Badge file since it'd be best to refactor badge instead of just having a variable set to false, so that should be done in a separate change.

Are you open for a PR to remove BadgeUtils.USE_COMPAT_PARENT?

MGaetan89 avatar May 10 '24 06:05 MGaetan89

sure if you'd like to contribute feel free to do so and we'll happily review it! :)

leticiarossi avatar May 10 '24 14:05 leticiarossi

I'll prepare a PR then 🙂 Just to be sure that we're aligned: the goal is to remove BadgeUtils.USE_COMPAT_PARENT and every it's used, correct?

MGaetan89 avatar May 10 '24 15:05 MGaetan89

that's right, we should remove the checks for BadgeUtils.USE_COMPAT_PARENT similar to how you removed the checks for API <= 19

leticiarossi avatar May 10 '24 16:05 leticiarossi

Ok, https://github.com/material-components/material-components-android/pull/4170 is ready when you have time to have a look 🙂

MGaetan89 avatar May 10 '24 21:05 MGaetan89