material-components-android-codelabs icon indicating copy to clipboard operation
material-components-android-codelabs copied to clipboard

shr_product_grid_fragment.xml changes in MDC-104 without explanation

Open ragraham91 opened this issue 7 years ago • 0 comments

Describe the bug In page 3 of MDC-104, we are told to add this code:

<LinearLayout
   style="@style/Widget.Shrine.Backdrop"
   android:layout_width="match_parent"
   android:layout_height="match_parent"
   android:gravity="center_horizontal"
   android:orientation="vertical"
   android:paddingTop="100dp"
   android:paddingBottom="100dp">

</LinearLayout>

Note paddingTop and paddingBottom of 100dp.

Further down the page, this has become:

<LinearLayout
   style="@style/Widget.Shrine.Backdrop"
   android:layout_width="match_parent"
   android:layout_height="match_parent"
   android:gravity="center_horizontal"
   android:orientation="vertical"
   android:paddingTop="88dp">

   <include layout="@layout/shr_backdrop" />
</LinearLayout>

Note paddingTop of 88dp and no paddingBottom. The change is not mentioned in the tutorial text.

Expected behavior Mention that the paddings need to be changed.

Screenshots If applicable, add screenshots to help explain your problem.

Codelab details (please complete the following information about the codelab):

  • MDC-104
  • Java
  • https://codelabs.developers.google.com/codelabs/mdc-104-java/index.html#2

Additional context Add any other context about the problem here.

ragraham91 avatar Sep 27 '18 10:09 ragraham91