Daniel Arndt
Daniel Arndt
You should still be able to open pull requests, though.
The failing compile line looks like the following to me: ``` [ 4%] Linking CXX shared library ../../../../../../lib/libsacado-gtest.so cd /home/darndt/trilinos/build_new/packages/sacado/test/GTestSuite/googletest/googletest && /soft/packaging/spack/gnu-ldpath/build/linux-sles15-x86_64/gcc-11.2.0/cmake-3.26.3-vnn7ncxwjjekhm5ehnwhk4w6tyoygc4p/bin/cmake -E cmake_link_script CMakeFiles/sacado-gtest.dir/link.txt --verbose=1 /soft/restricted/CNDA/updates/2023.10.15.001/oneapi/compiler/eng-20231009/linux/bin/icpx -fPIC -g -fp-model=precise...
https://github.com/trilinos/Trilinos/pull/9514 would probably solve this problem as well.
Fixed by https://github.com/trilinos/Trilinos/pull/12707.
> The safest way to fix this is to just match the exact and full string I want to match in one matcher. You would not even need a regex....
The errors look like ``` [...] [ 55%] Building CXX object tests/native/CMakeFiles/iterator.dir/iterator.cpp.o cd /tmp/stdBLAS/build/tests/native && /opt/homebrew/bin/mpicxx -I/tmp/stdBLAS/build/include/experimental -I/tmp/stdBLAS/include -I/tmp/stdBLAS/build/_deps/mdspan-src/include -F/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk/System/Library/Frameworks -isystem /tmp/stdBLAS/build/_deps/googletest-src/googletest/include -isystem /tmp/stdBLAS/build/_deps/googletest-src/googletest -std=gnu++23 -arch arm64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk -MD...
> Why did you decide to guard adding the test versus setting the [DISABLED](https://cmake.org/cmake/help/latest/prop_test/DISABLED.html) property on it? `TriBITS` doesn't even give the test to `CMake` when this option is set.
We should consult `Trilinos` maintainers and @ndellingwood if this is good enough to deal with `Kokkos` tests in `Trilinos`.
> I would be curious to hear why this support for disabling tests is needed that cannot just be done with an exclude regex argument to ctest. https://tribits.org/doc/TribitsBuildReference.html#disabling-specific-tests even talks...