Daniel Arndt

Results 832 comments of Daniel Arndt

> @masterleinad, what about defining and running tests in a Trilinos build with internal Kokkos? Would that be supported? We can discuss if it's acceptable to temporarily disable all `Kokkos`...

> The more challenging part will be generating a KokkosConfig.cmake file for the build dir and the install dir and such issues. See https://github.com/kokkos/kokkos/pull/6078.

> So perhaps it is best to just disable Kokkos tests when building under Trilinos for the foreseeable future? Yes, let me hardcode that. @bartlettroscoe Any other comments on the...

@bartlettroscoe Hmm... Can you give me an example configuration? Locally I can configure with ShyLU support and OpenMP `ON` or `OFF` but of course, I get that error if I...

@bartlettroscoe So it looks like the configuration does `TPL_ENABLE_Pthread=ON` and we currently have https://github.com/trilinos/Trilinos/blob/c3b1a94753b3611e3f931a1a1b6e9f026b30ecb8/packages/kokkos/cmake/kokkos_tpls.cmake#L64 which should imply that the default for `Kokkos_ENABLE_THREADS` should be the same but this is not...

This means the `Trilinos` CI doesn't test the `THREADS` backend unless `Kokkos_ENABLE_THREADS=ON` is set.

> Thoughts on whether and what to print to hints that something happened when one run the example. Maybe just print ranks, indices and offsets similar to https://github.com/arborx/ArborX/blob/bf6f89b7d3d08fad3b8b0399f59aed0fe389df1b/examples/simple_intersection/example_intersection.cpp#L62-L72.

This should now be in decent shape to be reviewed again. As opposed to the initial approach, we now run a "classical" batched query.

We only see `SYCL` warnings that are being addressed in #923.

> I'd like to have NDEBUG (except for the final one checking the results) and print outs removed (print outs may be replaced by leading comments). > I think it...