Daniel Arndt

> @nmm0 @masterleinad Can we move forward with this PR? I am fine with merging this before #6793 if we move `rocThrust` support to a later pull request (possibly combining...

> What is your concern here? That the name `KOKKOS_ENABLE_ROCTHRUST` may change, or that the HIP path is not tested in CI? That the HIP part is not tested.

Retest this please.

> Which also makes me think that it is likely that the current sort implementation is broken for comparators if a user does not provide a host compatible comparator for...

> Is it because `Kokkos::View`s are not marked to be device copyable? `sycl::is_device_copyable)` is `false`. Our general approach to deal with non-device-copyable types is to just declare the whole functor...

> But does writing a specialization for Kokkos views resolve the issue here? ```diff diff --git a/core/src/Kokkos_View.hpp b/core/src/Kokkos_View.hpp index 484a0e6f6..74f734728 100644 --- a/core/src/Kokkos_View.hpp +++ b/core/src/Kokkos_View.hpp @@ -1996,6 +1996,11 @@ KOKKOS_INLINE_FUNCTION...

I'm happy to write a follow-up pull request that does the approach outlined in https://github.com/kokkos/kokkos/pull/6801#issuecomment-1969376720 instead.

``` BeginFence { "Kokkos::Impl::sycl_deallocate: fence before deallocate", 117440512,13} ``` is the culprit but I struggle to reproduce.

@ndellingwood I just tried again and used your build instructions. Can you confirm that you are still seeing the issue?

@ndellingwood Any chance you can debug that? Maybe add ```diff diff --git a/core/src/SYCL/Kokkos_SYCL_Space.cpp b/core/src/SYCL/Kokkos_SYCL_Space.cpp index 9cc8008cd..fe13bd2af 100644 --- a/core/src/SYCL/Kokkos_SYCL_Space.cpp +++ b/core/src/SYCL/Kokkos_SYCL_Space.cpp @@ -197,7 +197,7 @@ void sycl_deallocate(const char* arg_label, void*...