Simon Thiboutôt

Results 80 comments of Simon Thiboutôt
trafficstars

This is particularly annoying when uploading a lot of assets. Was there any progress toward this issue?

A significant improvement could be using an in-memory queue system (e.g., [fastq](https://www.npmjs.com/package/fastq)) and having the ability to retry not just failed asset uploads but also other parts of the CLI....

I tested those changes with a 62.7 GB upload (12k files), but I did not write any tests; let me know if you would like some tests. 🙂

> > I tested those changes with a 62.7 GB upload (12k files), but I did not write any tests; let me know if you would like some tests. 🙂...

@zackpollard @jrasm91 I'm not sure what the best strategy for testing the upload retry could be. This test may not be an e2e test. I thought of mocking the HTTP...

> Yeah, good point. I don't see any great way to accomplish that in our actual e2e environment. The only thing i can think of is doing something like executing...

@zackpollard @jrasm91 This is ready for review. I did my best to mock with accuracy, inspecting the requests made in the e2e tests. I'm waiting for your feedback! 🙂

This does not work in a monorepo setup.

I'm having the same issue.