mason.nvim
mason.nvim copied to clipboard
Add prisma-fmt to the regestry
Hi there
Close #393
Thanks for good first issue mark.
Take care
Cool! When the issue was created I took a quick look at it. After having done some research now again I've come to the same conclusion: The prisma formatter is generally bundled with the
prismanpm package itself. This npm package ships with prebuilt binaries (which behind the scenes are hosted by their "@prisma/engines" package).I'm a bit worried about landing this because:
- It needs nightly rust toolchain to be installed. I'm pretty confident this means a vast majority will be excluded from using this package.
- It uses an unstable source (git HEAD).
I'm wondering if it would be better to just provide a
prismapackage (which maps to theprismanpm package)? I also wonder why there's aprisma-fmtformatter in null-ls - exactly which executable is this formatter meant to target?
You're correct. It's bundled with Prisma and if you have Prisma lsp it should work as a language formatter.
I think they extracted it to a separate package to make maintenance easier.
FWIW, they recommend installing Prisma as a project-local dependency: https://www.prisma.io/docs/concepts/components/prisma-cli/installation#local-installation-recommended. I'm not opposed to adding prisma as a standalone package in Mason though (PR welcome)