react-lightning-design-system icon indicating copy to clipboard operation
react-lightning-design-system copied to clipboard

Popover is not controllable

Open stomita opened this issue 8 years ago • 1 comments

Currently the hidden property is used for representing default value, and the visibility is totally uncontrollable from outside. To be controllable from outside, change hidden property as controlled one and introduce defaultHidden property to tell the default visibility.

There are public component methods like hidden() or mouseEntered() which are not documented, and essentially not used (in any part of the rest of the code).

IMO making method public in React component is not in good manner to access the internal state - it should be totally be stateless by default.

stomita avatar Feb 14 '17 09:02 stomita

#231

costagolub avatar Sep 06 '17 06:09 costagolub