yojimbo icon indicating copy to clipboard operation
yojimbo copied to clipboard

Published 20 hours ago • verified publisher icon mas-bandwidth

m_sentPackets sequence fix & some other minor changes

Open jorgenpt opened this issue 3 years ago • 4 comments

  • Fix the assert that triggers if you only intermittently send reliable messages
  • Clean up the acked field which isn't being used

jorgenpt avatar Jan 14 '22 23:01 jorgenpt

Not sure why this is failing on macOS, I'll investigate.

jorgenpt avatar Jan 14 '22 23:01 jorgenpt

Huh. It ran fine when it was re-run, and I wasn't able to reproduce.

jorgenpt avatar Jan 14 '22 23:01 jorgenpt

@gafferongames whenever you have time I'd love to hear your thoughts on this PR. It looks like a great fix to get rid of having to send dummy reliable packets to avoid the issue, but was curious as to what you think.

JoeShiverblade avatar Jan 31 '22 19:01 JoeShiverblade

I'm concerned around the heisenbug on tests. Please run locally on MacOS and loop the tests (while true). If it's an intermittent timing related test failure, then this approach usually catches it.

gafferongames avatar Jan 31 '22 21:01 gafferongames

I believe this has been fixed in another PR. If I'm wrong, please let me know.

gafferongames avatar Dec 24 '23 14:12 gafferongames