prometheus-nginxlog-exporter icon indicating copy to clipboard operation
prometheus-nginxlog-exporter copied to clipboard

Add experimental Docker log follower implementation

Open tjb346 opened this issue 5 years ago • 10 comments

I saw this issue was marked as help wanted here https://github.com/martin-helmich/prometheus-nginxlog-exporter/issues/67 and decided to take a stab at it since I need this feature too.

The instructions on how to use are in the README, but basically you enable experimental features, mount the host's docker socket to the container, and add the following to the config:

namespace "nginx" {
  source {
    docker {
      container = "nginx_container_name"
    }

    // ...
  }
}

tjb346 avatar May 12 '20 01:05 tjb346

Code Climate has analyzed commit a00de115 and detected 0 issues on this pull request.

View more on Code Climate.

qlty-cloud-legacy[bot] avatar May 12 '20 01:05 qlty-cloud-legacy[bot]

Oh, wow. 😍 Thanks for the contribution. 👍 I'll take a look shortly.

martin-helmich avatar May 12 '20 05:05 martin-helmich

Tried to use this with https://github.com/nginx-proxy/nginx-proxy, but nginx-proxy prepends "nginx.1 |" to the log messages, don't see a way configure the 'format' to include/ignore those, would love to hear if it i possible

selckin avatar Jun 10 '20 16:06 selckin

There has not been any activity to this pull request in the last 30 days. It will automatically be closed after 7 more days. Remove the stale label to prevent this.

helmich-bot avatar Jul 11 '20 00:07 helmich-bot

I've tested this feature and works correctly. Do you think to reopen the pull request and merge it in the next release?

zidagar avatar Nov 04 '20 09:11 zidagar

I could use this as well. Is there any other interest in re-opening this PR?

jasenmh avatar Dec 03 '20 23:12 jasenmh

Re-opening for now. I still remember wanting to test some edge cases on this, but then I lost track of this one... I'll give it another look shortly.

martin-helmich avatar Dec 13 '20 11:12 martin-helmich

There has not been any activity to this pull request in the last 30 days. It will automatically be closed after 7 more days. Remove the stale label to prevent this.

helmich-bot avatar Jan 13 '21 01:01 helmich-bot

There has not been any activity to this pull request in the last 30 days. It will automatically be closed after 7 more days. Remove the stale label to prevent this.

helmich-bot avatar Feb 13 '21 00:02 helmich-bot

This would be extremely helpful ! Any chance to have it reviewed & merged soon ?

giom-l avatar Feb 15 '23 11:02 giom-l