ChordSheetJS icon indicating copy to clipboard operation
ChordSheetJS copied to clipboard

Improve chord parsing in ChordProParser

Open martijnversluis opened this issue 3 years ago • 2 comments

As concluded in #461, the chord parsing format in ChordProParser is not inclusive enough and not consistent with how Chord.parse functions. The format should be extended to match all possible chords. If possible, it would be nice to have shared logic for recognising and parsing chords.

martijnversluis avatar Apr 15 '22 11:04 martijnversluis

I'm not sure how he ChordProParser HtmlDivFormatter chooses how to make paragraphs. I have what I think are 2 identical formats but one is making paragraphs after every line and the other behaves what I would consider correctly.

paulrobertpine avatar May 05 '22 13:05 paulrobertpine

Hi @paulrobertpine,

Thanks for reaching out. I think what you're describing is different from this issue here. Would you mind creating a new issue, also providing the code and chord sheet(s) you're using? I'll try if I can find a solution.

martijnversluis avatar May 12 '22 06:05 martijnversluis