django-rest-marshmallow icon indicating copy to clipboard operation
django-rest-marshmallow copied to clipboard

ModelSerializer support?

Open mustaqeem opened this issue 8 years ago • 4 comments

Is there any support for ModelSerializer?

It is useless to define all the fields again in the Schema.

mustaqeem avatar Oct 07 '17 04:10 mustaqeem

ModelSerializer is not currently supported. I would certainly review and merge a PR adding it though =)

sloria avatar Dec 08 '17 02:12 sloria

I'd like to have a go at this, but I am very new to Python, Django and Marshmallow o_O

However, would I be correct in thinking implementing it would be along the lines of the marshmallow-sqlalchemy ModelSchema implementation? https://github.com/marshmallow-code/marshmallow-sqlalchemy/blob/dev/src/marshmallow_sqlalchemy/schema.py

There are no contributing guidelines for this repo, but can I assume they are the same as the marshmallow_sqlalchemy ones? https://github.com/marshmallow-code/marshmallow-sqlalchemy/blob/dev/CONTRIBUTING.rst

mickyginger avatar Aug 18 '19 21:08 mickyginger

Thanks for offering to work on this! Yes, I think it will look along the lines of marshmallow-sqlalchemy. It's probably also worth looking at the implementation of ModelSerializer in DRF.

The contributing guidelines for this project should match the other marshmallow libs.

sloria avatar Aug 18 '19 21:08 sloria

I'd highly appreciate this as well!

faridelnasire avatar Oct 09 '21 04:10 faridelnasire