django-rest-marshmallow icon indicating copy to clipboard operation
django-rest-marshmallow copied to clipboard

Add Azure Pipeline and add webhook to github

Open davidzwa opened this issue 5 years ago • 8 comments

@sloria I can help set up Azure Pipelines. Do you have a reference pipeline file for travis I can take a look at?

On the pipeline matter:

  • What/where is the python matrix/strategy for TravisCI you currently use?
  • Are you using pytest?

On administration:

  • What is your Azure account I can use to invite you as admin to the project?
  • How do I make sure the DevOps falls under your org/name with you as admin? I have created https://dev.azure.com/marshmallow-code/django-rest-marshmallow by following https://docs.microsoft.com/en-us/azure/devops/pipelines/repos/github?view=azure-devops&tabs=yaml
  • Can I PR an azure-pipeline.yml later, so that you can setup the github action/hook side of things?
  • I need you to authorize the Azure project to use the github webhook. If I do it, it goes to my github account only, which I want to avoid. image

davidzwa avatar Apr 10 '20 18:04 davidzwa

Thanks for offering to take this on. Take a look at the other repos in marshallow-code for an example. I'll still need to authorize AP on this repo, but you can still send a PR adding the config file

sloria avatar Apr 10 '20 18:04 sloria

Hmm, I see. If you give me your Azure account, I can let you authorize and PR the azure-pipelines.yml file with one click. The work is in the debugging step of the pipeline I presume, so I don't think just adding the .yml like your azure-pipelines.yml example really bears a lot of meaning if I cant test it.

I'll wait for you to send me your Azure account name, so you can be invited and authorizing the org / take over permissions.

davidzwa avatar Apr 10 '20 18:04 davidzwa

I've just added the app to this repo and added it under the same Azure project that has all the other marshmallow libs. I think if you send a PR adding the azure-pipelines.yml it should trigger a build.. maybe...?

sloria avatar Apr 10 '20 19:04 sloria

If the webhook is setup it should! I think that still needs to be done first. The marshmallow DRF repo needs to be known to azure for anything to trigger. Please click 'add pipeline' > 'github repos' > add python azure-pipelines.yml > make PR.

I can then start looking at the PR when it's here on github.

davidzwa avatar Apr 11 '20 08:04 davidzwa

ok, here's the PR generated through AP: https://github.com/marshmallow-code/django-rest-marshmallow/pull/140/files

sloria avatar Apr 12 '20 15:04 sloria

Perfect! I will have to make another PR, as I need to fork, but now the webhook should work. Well done!

davidzwa avatar Apr 12 '20 19:04 davidzwa

The pipeline works! @sloria next step is to make it a requirement for pull-requests once your content with PR #141

davidzwa avatar Apr 12 '20 20:04 davidzwa

See PR for info about status, as I need a bit of feedback.

davidzwa avatar Apr 12 '20 21:04 davidzwa