rust-base64 icon indicating copy to clipboard operation
rust-base64 copied to clipboard

Published 20 hours ago • verified publisher icon marshallpierce

Precise length checking in `decode_slice`

Open marshallpierce opened this issue 2 years ago • 4 comments
trafficstars

It would be good to have the length error only emitted when we know it to be required.

marshallpierce avatar Jan 01 '23 18:01 marshallpierce

Any chance this gets fixed?

davidzeng0 avatar Nov 06 '23 05:11 davidzeng0

Any chance this gets fixed?

You're welcome to propose a PR.

marshallpierce avatar Nov 06 '23 22:11 marshallpierce

What's going on with pull #227? Is it stalled? It seems like it fixes a lot of issues. Let me know if I should start fresh or continue from that pull request.

davidzeng0 avatar Nov 06 '23 23:11 davidzeng0

I don't know the status. Presumably the author got busy with real life, etc. Small PRs are more likely to be reviewed and merged promptly since they require smaller blocks of time to review.

marshallpierce avatar Nov 07 '23 16:11 marshallpierce

Note that this is appears to be a regression. Code used to work fine with base64 0.13 now returns an incorrect OutputSliceTooSmall error under 0.21.

mqudsi avatar Feb 27 '24 18:02 mqudsi

Hm, that's not good. I'll see if I can find time to address this myself.

marshallpierce avatar Feb 27 '24 20:02 marshallpierce

Fix released in 0.22.0.

marshallpierce avatar Mar 02 '24 01:03 marshallpierce

Thanks! 🙏

mqudsi avatar Mar 02 '24 01:03 mqudsi