rust-base64 icon indicating copy to clipboard operation
rust-base64 copied to clipboard

Clippy nightly false positive

Open danieleades opened this issue 3 years ago • 4 comments

clippy is throwing a false positive

cargo +nightly clippy                                                                                                                                 101 ✘ 
    Checking base64 v0.20.0-alpha.1 (/home/dan/Code/rust/rust-base64)
error: parameter is only used in recursion
   --> src/engine/fast_portable/mod.rs:203:34
    |
203 | pub(crate) const fn decode_table(alphabet: &Alphabet) -> [u8; 256] {
    |                                  ^^^^^^^^ help: if this is intentional, prefix with an underscore: `_alphabet`
    |
note: the lint level is defined here
   --> src/lib.rs:86:5
    |
86  |     warnings
    |     ^^^^^^^^
    = note: `#[deny(clippy::only_used_in_recursion)]` implied by `#[deny(warnings)]`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion

error: could not compile `base64` due to previous error

see https://github.com/rust-lang/rust-clippy/issues/8629

danieleades avatar May 01 '22 08:05 danieleades

Technically you linked the wrong issue. It should be https://github.com/rust-lang/rust-clippy/issues/8556 and I already reported that there 😅

hellow554 avatar May 01 '22 12:05 hellow554

The issued is closed and should be working as intended. Can you Test it again please?

hellow554 avatar Aug 20 '22 09:08 hellow554

i'm still seeing this issue with rustc 1.65.0-nightly (015a824f2 2022-08-22)

danieleades avatar Aug 24 '22 05:08 danieleades

The changes haven't reached rust nightly yet as clippy & the rust repo are synced up periodically. Should be some time this/next week

Alexendoo avatar Aug 25 '22 09:08 Alexendoo

No issues with stable or nightly clippy currently.

marshallpierce avatar Nov 30 '22 14:11 marshallpierce