Philippe Marschall

Results 166 comments of Philippe Marschall

Don't forget to fix #1053 as well.

@jbrichau has this been fixed by #1244?

No error messages, just no events reported.

> As a user, I always use try-w/-resources on everything I pass into any library function. If some consumer closes my streams, I'd be surprised. I feel the same way....

Here are TCK tests for the behavior as currently speced according to my reading #351.

Some further arguments against closing The [toJson](https://www.javadoc.io/doc/org.eclipse/yasson/latest/org.eclipse.yasson/org/eclipse/yasson/YassonJsonb.html) methods of `YassonJsonb` leave the parsers and generators open. For the generators this is mentioned in the API contract. > The generator is...

> Seems relate to https://eclipse.dev/eclipse/news/4.30/pde.php#unnecessary-attributes-removal but I can't understand why no one else complained yet. Possible but my understanding is Tycho ignores `unpack` in `feature.xml` and instead relies on `Eclipse-BundleShape`...

> @marschall can you please provide an example at best as an integration-test to demonstrate the issue? I'll see what I can do. I may take some time. > so...

With Batch 5 it's now easily possible to write integration tests that do not need a `javax.sql.DataSource`. An example can be found here: https://github.com/marschall/spring-batch-inmemory/blob/master/src/test/java/com/github/marschall/spring/batch/inmemory/InMemoryBatchConfigurationTests.java Or here: https://github.com/marschall/spring-batch-inmemory/blob/master/src/test/java/com/github/marschall/spring/batch/inmemory/NullBatchConfigurationTests.java

Thanks, will be resolved in https://github.com/SeasideSt/Grease/pull/181.