PhoneNumberKit icon indicating copy to clipboard operation
PhoneNumberKit copied to clipboard

Unmark targets in example projects as shared - carthage fix

Open niorko opened this issue 3 years ago • 3 comments
trafficstars

Carthage is trying to load all the projects recursively.

These projects have their targets shared

  • AsYouType
  • PhoneBook

It was causing issues with our restricted setup as our build machine has restricted access to the outside network.

build	17-May-2022 13:25:27	*** Invalid cache found for PhoneNumberKit, rebuilding with all downstream dependencies
error	17-May-2022 13:25:33	A shell task (/usr/bin/xcrun xcodebuild -project *******************/Carthage/Checkouts/PhoneNumberKit/examples/AsYouType/Sample.xcodeproj CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES -list) failed with exit code 74:
error	17-May-2022 13:25:33	xcodebuild: error: Could not resolve package dependencies:
error	17-May-2022 13:25:33	  Failed to clone repository https://github.com/marmelroy/PhoneNumberKit.git:
error	17-May-2022 13:25:33	    Cloning into bare repository '/Users/******/Library/Developer/Xcode/DerivedData/Sample-boukitasrkkjuddzxegrawnsxpcb/SourcePackages/repositories/PhoneNumberKit-d01b822f'...
error	17-May-2022 13:25:33	    fatal: unable to access 'https://github.com/marmelroy/PhoneNumberKit.git/': Received HTTP code 407 from proxy after CONNECT

Please consider merging this PR - it might help some people. Thanks

niorko avatar May 17 '22 13:05 niorko

Is there any special configuration that makes Carthage behave like this? I've done a small test here and those targets are not being loaded by Carthage.

bguidolim avatar May 17 '22 13:05 bguidolim

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jul 17 '22 03:07 github-actions[bot]

I am not really sure how to replicate it on my machine. It is the issue on the remote one - running gitlab runner. It somehow tries to build the example project while building Carthage dependencies and it fails. So this was my instinct. Maybe it is a Carthage bug, but I didn't have a time to play with that. Quick fix for us is to remove examples directory.

niorko avatar Jul 20 '22 08:07 niorko

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 18 '22 04:10 github-actions[bot]