react-admin icon indicating copy to clipboard operation
react-admin copied to clipboard

Published 20 hours ago • verified publisher icon marmelab

Variant props is not applied on RichTextInput

Open thibault-barrat opened this issue 3 years ago • 2 comments

What you were expecting: I want to be able to use variant on RichTextInput in order to have a coherent style with other inputs.

What happened instead: Use of variant props on RichTextInput doesn't change the style of the input.

Steps to reproduce: Try to add variant="standard" on a RichTextInput

Related code: See PostEdit.tsx in https://codesandbox.io/s/angry-https-x03e37

Environment

  • React-admin version: 4

thibault-barrat avatar Jun 24 '22 11:06 thibault-barrat

Thanks for reporting Thibault!

antoinefricker avatar Jun 27 '22 09:06 antoinefricker

React Admin uses tiptap for the RichTextInput, consequently it does not support Material UI variant property. We should port MUI theme configuration for the three variants over the tiptap/.ProseMirror context. We do not intend to implement this in a close milestone but would be pleased to review any related pull request. 👍

antoinefricker avatar Jun 27 '22 14:06 antoinefricker

There is no traction from the react-admin community on this feature request, so I'll close it. But feel free to open a PR is you have an implementation!

fzaninotto avatar Oct 26 '22 15:10 fzaninotto