demoinfocs-golang icon indicating copy to clipboard operation
demoinfocs-golang copied to clipboard

Possible panic since v4.1.0

Open akiver opened this issue 1 year ago • 1 comments
trafficstars

Describe the bug

Since the v4.1.0 that introduced POV support for CS2 demos, many fields may be nil and cause panic for consumers.

To Reproduce

Git clone the CS demo analyzer repo and run the tests in verbose mode (make test-verbose).

You will have this output. There is a panic and many warnings about fields being nil - it was not the case before v4.1.0.

Expected behavior

No panic or nil fields.

Library version v4.1.0

Additional context

I didn't dig into it yet, maybe we should revert commits and release a v4.2.0 until it's resolved WDYT @markus-wa ?

akiver avatar Mar 29 '24 21:03 akiver

I think we should fix-forward on this. I do appreciate this can be a problem, but POV support is a valuable feature and we should keep supporting it while fixing all the problems with it.

markus-wa avatar Mar 30 '24 01:03 markus-wa