Mark Massoud
Mark Massoud
Sure, I am passing in those arguments for a sitespeed report: ``` https://www.mydomain.com -b chrome --speedIndex --html.showAllWaterfallSummary ``` and another sitespeed report with those ones: ``` https://www.mydomain.com/some/path/with/same/domain.html -b chrome --speedIndex...
My suggestion would be to recognize the placeholder `%timestamp%`, so we could pass e.g. `--s3.path CUSTOM_FOLDER/%timestamp%`, and inside of [this IF block](https://github.com/sitespeedio/sitespeed.io/blob/master/lib/core/resultsStorage/index.js#L24) on line 24, have it as ``` if...
Ah! we have them all in the same bucket `sitespeed-reports`, to keep things organized. Yes they collide on S3 when getting saved...
I've done the upgrade here: https://github.com/digital-dynamite/serverless-google-cloudfunctions-awesome/commit/7d1f4348204a9ea26c14beef4e1c2e097011275b Hopefully it can help someone.
I was about to open the same PR, thanks @CaptainJojo! Question: Is it possible to add the `entryPoint` to the function object? ``` functions: images: handler: images entryPoint: myExportedFunction #defaults...
Based on your PR, I've ended up writing my own one (PR #98) , because I found that yours was changing the logic a lot, which is breaking changes to...
@CaptainJojo fun fact, i think your PR was a must as well hehe, but should be optional by passing an option in the `serverless.yml`, e.g. `prependStage: true` and `prependService: true`....
In my opinion I think it is, so there is no conflicts in naming when 2 functions have the same name. We can compare with the AWS plugin to see...
Awesome thanks!! @pmuens any thoughts on that?