java-client-api icon indicating copy to clipboard operation
java-client-api copied to clipboard

OkHttpServices::getIteratedResourceImpl ignores given mimetypes

Open ralfhergert opened this issue 6 years ago • 2 comments

https://github.com/marklogic/java-client-api/blob/9803cca4cfdeecde4b9d8e1ab0396e45814a2b02/marklogic-client-api/src/main/java/com/marklogic/client/impl/OkHttpServices.java#L3078

Method getIteratedResourceImpl(...) takes a String-array of accepted mimetypes, but never uses them.

ralfhergert avatar Nov 21 '18 09:11 ralfhergert

The fix will be just to refactor at the start of a release cycle to remove the superfluous parameters.

ehennum avatar Oct 04 '21 18:10 ehennum

Removing dead parameters is good for code quality, but this fix is a low priority because it is entirely internal.

ehennum avatar Feb 15 '22 19:02 ehennum

Better late than never on this cleanup - see #1465 . Will include this in 6.0.0 so we can remove it at some point, unless we decide it's a bug that the argument exists in 6 methods in ResourceServices.

rjrudin avatar Nov 17 '22 20:11 rjrudin