vue-theme-vscode icon indicating copy to clipboard operation
vue-theme-vscode copied to clipboard

Improve Python Colors

Open lovetoburnswhen opened this issue 3 years ago • 7 comments

A few scopes I noticed were missing:

  • keyword.control.import
  • string.quoted.docstring

lovetoburnswhen avatar Jun 22 '22 18:06 lovetoburnswhen

Hey @mariorodeghiero - would you be able to promote it..?

nirfuzz avatar Sep 18 '22 13:09 nirfuzz

@nirfuzz and @lovetoburnswhen can you paste a python repository mentioning where the piece of code contains this? so I can follow it as an example. Also, feel free to send PR's with the changes if you want, I really need code contributors.

mariorodeghiero avatar Sep 19 '22 07:09 mariorodeghiero

✅ Added support on V2 branch, this issue will be closed soon.

mariorodeghiero avatar Oct 03 '22 06:10 mariorodeghiero

@nirfuzz @lovetoburnswhen V2 is available, you can check the list of improvements here v2

  • keyword.control.import ✅

About string.quoted.docstring can you provide some python code that I can have a look at and try to improve the colors a bit? I will focus on the docstring now.

mariorodeghiero avatar Oct 04 '22 19:10 mariorodeghiero

imports look great, though now there seems to be some inconsistency in string highlighting (not only docstring):

image

and another inconsistency with modules / methods: image

plus - no different colors for nested parentheses.

@mariorodeghiero

nirfuzz avatar Oct 04 '22 21:10 nirfuzz

@nirfuzz thanks for letting me know, I will check it.

mariorodeghiero avatar Oct 06 '22 09:10 mariorodeghiero

@nirfuzz I pushed a v2.0.1 with some Python support.

I will try to review a bit more once I have some time available(Now I am focused to improve the current colors) but for a while I think is ok. I just pull an open-source python project and I added some support.

Note: about no different colors for nested parentheses, I think is better that way for working with javascript, I tried some colors but I didn't like them.

Screenshot 2022-10-12 at 22 07 39

mariorodeghiero avatar Oct 12 '22 20:10 mariorodeghiero