django-ltree icon indicating copy to clipboard operation
django-ltree copied to clipboard

Hard fork at `django-ltree-2`

Open baseplate-admin opened this issue 1 year ago • 12 comments

Hi,

I don't think this repository is in development anymore, I have a fork at django-ltree-2 which addresses :

  • #16
  • #15
  • #20

Along with some new features available in python :

  • https://github.com/baseplate-admin/django-ltree-2/pull/3 [ #26 ]
  • https://github.com/baseplate-admin/django-ltree-2/pull/4 [ #24 ]
  • https://github.com/baseplate-admin/django-ltree-2/pull/11 [ #27 ]

Along with automatic label generation

  • https://github.com/baseplate-admin/django-ltree-2/pull/6

Along with documentation

The test suits are identical. The project is a drop in replacement for django-ltree.

I am open to collaborations, if django-ltree is open to development, I will archive the fork.

Thanks a bunch

baseplate-admin avatar Feb 22 '24 16:02 baseplate-admin

Thank you, @baseplate-admin! I really appreciate your stepping in for the existing users

mariocesar avatar Dec 17 '24 21:12 mariocesar

Heey, thanks for reaching out, if this package is maintained, i dont see the reason to continue development of django-ltree-2, ( if you wish, i can archive django-ltree-2 )

Judging by

  • https://github.com/mariocesar/django-ltree/issues/22

If you need any help ( or want to merge some changes back ) i would be very glad to help you.

Thanks and welcome back :D

baseplate-admin avatar Dec 17 '24 21:12 baseplate-admin

Thanks, @baseplate-admin! I'm happy with that. I'm currently fixing local things for the project, but I can merge your fork, and we can continue together.

To bless this, you can create a "Merge django-ltree-2" ticket, and we can work together there in a branch for the merge.

mariocesar avatar Dec 17 '24 21:12 mariocesar

To bless this, you can create a "Merge django-ltree-2" ticket, and we can work together there in a branch for the merge.

Sounds very very good proposal :)

I would be very willing to merge our project.

Do you have anything that you dont like? These are 3 extra features i added:

  • https://github.com/baseplate-admin/django-ltree-2/pull/3
  • https://github.com/baseplate-admin/django-ltree-2/pull/4
  • https://github.com/baseplate-admin/django-ltree-2/pull/11

baseplate-admin avatar Dec 17 '24 22:12 baseplate-admin

The three are great !

https://github.com/baseplate-admin/django-ltree-2/pull/3 ✅ https://github.com/baseplate-admin/django-ltree-2/pull/4 ✅ https://github.com/baseplate-admin/django-ltree-2/pull/11 ✅

mariocesar avatar Dec 17 '24 22:12 mariocesar

Hi, I have submitted PR for all the improvements that i had.

Also i have a new proposal to get path value:

  • https://github.com/baseplate-admin/django-ltree-2/pull/6

But i am afraid this is a breaking change, it will require the release of a new version.

on a side note, i think you should add some more maintainers to this repository, so that if you need some time off, they can take some of the burden off you

baseplate-admin avatar Dec 19 '24 03:12 baseplate-admin

Thanks for all your work! All look awesome.

Yes Label generations needs more work, I understand what you want to do.

One thing that I want to do is try to create a path to migrate from django-treebeard with their paths 0001.0002.0003 pattern, and I know it will need some refactor on the label to do so

mariocesar avatar Dec 19 '24 22:12 mariocesar

Hi,

I'm looking for a django lib to use the ltree extension and I don't which one to choose between this one and django-ltree-2. Is it still a work in progress to merge both in the current project or are you diverging and the idea to have only one lib is no more something you are working on ?

Thanks

lunika avatar Feb 17 '25 16:02 lunika

The ltree main is now merged with the latest from django-ltree-2. You can use it with a development install via pip. Currently, there is no new release for the merged project, as some tests and packaging work are still in progress.

mariocesar avatar Feb 17 '25 16:02 mariocesar

Thank you.

So the new requirements of the ltree's main branch follow the one from ltree-2 ?

  • Python 3.9 to 3.13 supported.
  • PyPy 3.9 to 3.10 supported.
  • Django 4.2 to 5.1 supported.
  • Postgres 13 to 17 supported.

lunika avatar Feb 17 '25 16:02 lunika

Yes, that is right

mariocesar avatar Feb 17 '25 16:02 mariocesar

Hi, sorry for late response.

Python 3.9 to 3.13 supported. PyPy 3.9 to 3.10 supported. Django 4.2 to 5.1 supported. Postgres 13 to 17 supported.

I recon it would work for other (older) versions too. These versions are actively tested in github-actions

Is it still a work in progress to merge both in the current project or are you diverging and the idea to have only one lib is no more something you are working on ?

Yep, most of the changes are merged in mainline django-ltree, the only change is that, django-ltree-2 does automatic label generation. That means if you use django-ltree-2 and then switch back to django-ltree, you might have to tweak the LABEL_SIZE in django-ltree

  • https://github.com/baseplate-admin/django-ltree-2/pull/6

Thank you for your interest.

baseplate-admin avatar Feb 28 '25 08:02 baseplate-admin