Marcus Pousette

Results 77 comments of Marcus Pousette

`http.Server` and `https.Server` has that method since NodeJs 18.2.0 ```ts /// it-ws/server.ts async close (): Promise { await new Promise((resolve, reject) => { this.server.closeAllConnections() this.server.close((err) => { if (err !=...

Actually the closeAllConnections trick does work since the connection is a `tcp` one (?) The close connection manager first trick seems to always work. Also adding like a 5s delay...

Ye the whole thing about aborting Websocket connections before closing does not seem to have an impact. Only the two things I mentioned in my last comment did mitigate the...

> Looking at the code, the TCP listener [aborts](https://github.com/libp2p/js-libp2p/blob/main/packages/transport-tcp/src/listener.ts#L334) each connection on close whereas the WebSocket transport tries to [close them gracefully](https://github.com/libp2p/js-libp2p/blob/main/packages/transport-websockets/src/listener.ts#L94). That would explain something!

Yeap, but that will also make it point away from `cwd`.. Did a quick PR to show what I mean https://github.com/hugomrdias/playwright-test/pull/653 Naming is not really a problem I think, because...

Thank you for creating this issue, and providing the links. Definitely needed!