logger_logstash_backend icon indicating copy to clipboard operation
logger_logstash_backend copied to clipboard

Allow protocol to be configured, so either UDP or TCP sockets can be used

Open KronicDeth opened this issue 9 years ago • 7 comments

This is a big change. If you don't want to include (and have to maintain) TCP support in your project, that's fine, I'll just keep using it from my fork on github.

KronicDeth avatar Jun 21 '16 19:06 KronicDeth

Hi!

Thanks for the contribution :) I'd love to have this, could you first make sure that all the tests pass with the previous elixir versions? I'll try to look this in depth in the following days. Thanks!

marcelog avatar Jun 22 '16 12:06 marcelog

What version range do you want me to test on? I was running this on 1.2.5

KronicDeth avatar Jun 22 '16 13:06 KronicDeth

Hi!

The travis.yml file contains the versions that Travis is testing on, and you can see the build errors by clicking on "Details" above, the tests are run automatically with every push to the branch where this pull comes from.

marcelog avatar Jun 22 '16 13:06 marcelog

Sorry, for the long delay. I was pulled off onto other projects not using the logger.

KronicDeth avatar Jul 19 '16 15:07 KronicDeth

I added fda5517 after we found issues with not having the disconnect recovery also applied to startup: there were cases where our Kibana instance was down we when deployed the app and it would stop the app because the logger kept dying.

KronicDeth avatar Jul 20 '16 19:07 KronicDeth

Thank you @KronicDeth for the follow up and for updating this pull!

marcelog avatar Jul 20 '16 21:07 marcelog

@marcelog it looks like one of the tests failed with an EADDRINUSE. I haven't been able to eliminate those errors from the tests reliably even with reuseaddr. You'll have to hit rebuild in travis for me to see if the error is transient.

KronicDeth avatar Jul 20 '16 21:07 KronicDeth