Update `index-of` and `slice` expression Android 11.0.0

[louwers]

Will remove Draft status of this PR once 11.0.0 has been released.

Resolves #159

[HarelM]

@louwers any updates on this? Can this be merged?

[louwers]

@HarelM No it is not released yet.

[acalcutt]

Just an FYI, I just made a PR that adds 'slice' and 'index-of' to node also https://github.com/maplibre/maplibre-native/pull/2047

If this gets merged does the node version need to be added similar to this PR?

[louwers]

@acalcutt We are not currently tracking style support of Node.js. As you can see:

https://maplibre.org/maplibre-style-spec/expressions/

If you want to, you can add it, but you'd have to go over all the other things as well!

[ghost]

I didn't see this PR earlier when creating https://github.com/maplibre/maplibre-native/discussions/2078 but I believe the style-expression changes should be backported to Android maplibre 10.x, too.

It's not a breaking change, so it makes sense to provide it for Android maplibre 10.x instead of Android maplibre 11.x. Otherwise apps can't use the new style spec feature before also upgrading to Android 11.x (which is sometimes beyond control of style designers who require slice and index-of and potentially significant work for developers or even impossible for end-users in case system requirements change; e.g. OpenGL ES 3.x).

Backporting them would also make them available immediately; which is probably better than waiting for Android maplibre 11.x to be completed. Feature was merged in May, unmasking feature [this PR] was planned in October, in December [question above] it still wasn't done. Feature should have been released already but it's held back by Android maplibre 11.x which should be developed in a separate branch altogether (as Android maplibre 10.x should likely still receive security updates or bugfixes... or non-breaking features) = there shouldn't be any cost in backporting it to Android maplibre 10.x.

[HarelM]

@louwers this is a reminder since I saw you are creating apre release of 11.

[ghost]

I didn't even remember this PR; it should be changed to 10.3.x after https://github.com/maplibre/maplibre-native/pull/2135 (which should have been released already)

[louwers]

There's no official release out with these features.

[HarelM]

@louwers didn't you release version 11?

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.56%. Comparing base (bab15e3) to head (0e97811). Report is 7 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #362   +/-   ##
=======================================
  Coverage   92.56%   92.56%           
=======================================
  Files         104      104           
  Lines        4616     4616           
  Branches     1301     1301           
=======================================
  Hits         4273     4273           
  Misses        343      343           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.