maplibre-navigation-ios icon indicating copy to clipboard operation
maplibre-navigation-ios copied to clipboard

Branch cleanup

Open wipfli opened this issue 1 year ago • 7 comments

Thanks for all the good contributions to this repo! We have seen quite some activity in the last few months which is nice.

Regarding branches, I suggest someone with knowledge of what is what goes through them and deletes all unused branches.

Usually in other repos in the MapLibre org we do the following:

  • normal contributions are made on branches of a fork, for example on the repo wipfli/maplibre-navigation-ios
  • larger contributions that take weeks to months and that are composed of many individual pull requests can be made on branches in the maplibre repo, i.e., maplibre/maplibre-navigation-ios

Would this approach also make sense to the contributors/maintainers of maplibre-navigation-ios?

wipfli avatar Jul 15 '24 08:07 wipfli

I think the "delete branch after merge" setting may be off? I think most of the branches are probably stale after they got merged into main. I suggest turning that feature on to prevent branches from accumulating.

hactar avatar Jul 15 '24 09:07 hactar

Do you mean this one @hactar ?

image

wipfli avatar Jul 15 '24 11:07 wipfli

Yes. We still need to clean up the existing branches ourselves, but at least this would prevent the growth of unused branches in future.

hactar avatar Jul 15 '24 13:07 hactar

OK I changed that setting.

wipfli avatar Jul 15 '24 13:07 wipfli

I've browsed through them, cleaned up my own, and deleted a few that were clearly debug branches or commitless. I've also noticed that nearly all stale branches are by @birkskyum - maybe @birkskyum can tell us if there's any hidden gems in the branches we have?

hactar avatar Jul 15 '24 13:07 hactar

Oh really, I'll go through them later today

birkskyum avatar Jul 15 '24 14:07 birkskyum

UPDATE: I honestly don't know why I'm associated to all these branches. None of them appear familiar to me, so maybe it's leftovers from a repository transfer/onboarding. I'm not aware of anything of value in the branches, but I'd prefer to have someone with more experienced in navigation scan through the branches with my name on and make the judgement call.

birkskyum avatar Jul 15 '24 16:07 birkskyum