maplibre-gl-js icon indicating copy to clipboard operation
maplibre-gl-js copied to clipboard

Add some comments to transform class.

Open chrneumann opened this issue 1 year ago • 2 comments

Some comments i added to the Transform class that helped me to understand the internals.

chrneumann avatar Aug 03 '24 20:08 chrneumann

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.82%. Comparing base (8818fe3) to head (0f05c91). Report is 476 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4504      +/-   ##
==========================================
- Coverage   87.88%   87.82%   -0.07%     
==========================================
  Files         246      246              
  Lines       33450    33450              
  Branches     2208     2222      +14     
==========================================
- Hits        29399    29378      -21     
- Misses       3050     3052       +2     
- Partials     1001     1020      +19     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 03 '24 20:08 codecov-commenter

I'll hold up with this PR as the globe is doing some radical changes in transform class. If you could redo this PR against the globe branch it would be great.

HarelM avatar Aug 04 '24 11:08 HarelM

@chrneumann transform class has changed dramatically. I'll close this PR for now, if you feel this is needed please open a new PR against the new code. Thanks for taking the time to contribute!

HarelM avatar Jan 12 '25 07:01 HarelM