Trevor Manz

Results 354 comments of Trevor Manz
trafficstars

This change would have the additional added benefit of making our `HTTPStore` totally tree-shakable. As of now it's required to for the `instanceof HTTPStore` check, so even if you don't...

> make the signal part of the store using a Map that is updated per request or something and then call it the signal from the map given the tile...

The issue is that `omexml` is an OME construct and _not_ specific to Zarr. Zarr is a generic format for N-dimensional, and the `ZarrLoader` is simply a wrapper over one...

> @manzt I think the advantage of inheritance would be define things we use in other places in the code base clearly so that others know to use them, like...

> I hope that the new loader will still provide getRasterSize. That tripped me up because I expected to have width and height just like with OMETIFFLoader, causing NaN to...

I think this is kind of feature creep and something that can already be achieved with the utilities we provide. I'd rather see this for Avivator than adding another layer...

This already works just using the browser cache in vizarr: ![timeaxis](https://user-images.githubusercontent.com/24403730/97724259-15a41b80-1aa3-11eb-8525-8d3991d48850.gif)

Can confirm I see the same thing in React 17, but not other issues are apparent. FWIW, we've been using React17/PIXI.js 6.2 in `gos` for a bit.

> Did you happen to try running the schema on any of the viewconfs in test/view-configs? I just ran the test suite (sucessfully) locally. I can go through some of...

Let me know if that makes any sense or if you'd want to hop on a call to discuss anything.