Trevor Manz
Trevor Manz
> As for the "hundreds of data sets" issue, I think we'll need to think about this a bit...one option if you all have the capacity would be a URL...
Have been struggling to catch up on related viv thinfs. Will try to review this weekend!
I'm realizing this is basically a local CDN. Does something like that already exist for testing that we could proxy requests through and store?
I see. I have an idea for an alternative implementation but just haven't gotten around to it yet. I think we should be able to crawl the tests, intercept requests...
> Ideally one would run the tests locally to fetch the data. Have a look at #1118, I have implemented this... but the requests do not seem to be deterministic...
> Would it be possible to export those functions that you removed from hglib as another library (hglib.test.js or something to that effect)? They can be useful to plugin libraries...
Another option would be to move `test/utils/test-helpers.js` to the root of the repo and include this file in `package.json` files. That way consumers would have: ```js import * as hglib...
`lint-staged` and `husky` are also no longer necessary, and I can remove them in this PR if desired.
> Do you know why GitHub actions complains about the curly braces? This is from `eslint`, rule: `react/jsx-curly-brace-presence`. I'm also going to run `npm run lint -- --fix` which should...
hmm, seems like there are some conflicting rules for prettier and eslint. i'll fix